Version 1/6 - Next ยป - Current version
admin, 20/03/2012 14:39


Submitting Patches

If you've got a code change that fixes something or adds a feature, you're welcome to send in a patch. Please use the libavg-devel mailing list for patches and work off current svn.

Coding Conventions

Please follow the Coding Conventions.

Running the Tests

libavg contains a number of tests that run automatically and alert the user if anything doesn't work as expected. The tests are actually pretty comprehensive and find a lot of issues that would otherwise slip through the cracks. To run the tests, do a make check. The tests that have to do with images will save images for the failing tests in a resultimages/ subdirectory. For each failed test, there will be three images: the current result, the expected result, and a diff image - giving you a good clue about what's happening.

If you add a feature, please add a test (or several) that make sure the feature works. If you fix a bug, then there should habe been a test that finds the bug ;-), and it's appreciated if you add an appropriate test as well. (That also makes the bug reproducible, thus making your fix more likely to be applied).

Adding Documentation

If the patch changes the interface of libavg, we need an update to the reference documentation in libavg/sphinxdoc. To build the documentation, you need Sphinx installed:

1$ sudo easy_install -U Sphinx

The docs can be rebuilt by calling

1$ cd libavg
2$ ./makedocs.sh

Note that documentation is ordered alphabetically. This is not enforced by the sphinx, so new entries must be inserted in order.

Patch Granularity

Please submit patches that pertain to one issue at a time. Patches that fix several things at once are a hassle to apply in pieces. Also, small patches increase the chance that they'll be applied quickly, decreasing the change that the code will change while work on the patch is still progressing. (If that happens, you need to update the patch so it still applies to current svn, and that's a hassle.)